Messages in this thread | | | Date | Tue, 2 Oct 2012 14:57:08 +0200 | Subject | Re: [PATCH 11/12] pinctrl: samsung: use __devinit section for init code | From | Linus Walleij <> |
| |
On Tue, Oct 2, 2012 at 1:52 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Monday 01 October 2012, Linus Walleij wrote: >> On Fri, Sep 28, 2012 at 11:36 PM, Arnd Bergmann <arnd@arndb.de> wrote: >> >> > The samsung pinctrl driver has a probe function that is >> > __devinit and that calls a lot of other functions that are >> > marked __init, which kbuild complains about. >> > >> > Marking everything __devinit means that the code does not >> > discarded when CONFIG_HOTPLUG is set, which is a little >> > more wasteful, but also more consistent >> > >> > Without this patch, building exynos_defconfig results in: >> >> Acked-by: Linus Walleij <linus.walleij@linaro.org> >> >> I think the Samsing pinctrl driver has landed into next from some >> branch in ARM SoC so you probably know better than me >> where this thing should be merged... >> > > Sorry, I was too late for this one. Can you pick it up now that the > driver is merged?
Sure I've queued it for my -rc fixes.
Thanks, Linus Walleij
| |