Messages in this thread | | | Date | Tue, 2 Oct 2012 15:21:57 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/3] Add parenthesis to macros with complex values in trace.h |
| |
On Tue, Oct 02, 2012 at 08:54:28PM +0900, YAMANE Toshiaki wrote: > fixed some checkpatch below error. > -ERROR: Macros with complex values should be enclosed in parenthesis > > Signed-off-by: Toshiaki Yamane <yamanetoshi@gmail.com> > --- > drivers/staging/rts_pstor/trace.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h > index 740999c..a34493c 100644 > --- a/drivers/staging/rts_pstor/trace.h > +++ b/drivers/staging/rts_pstor/trace.h > @@ -78,8 +78,8 @@ do { \ > goto label; \ > } while (0) > #else > -#define TRACE_RET(chip, ret) return ret > -#define TRACE_GOTO(chip, label) goto label > +#define TRACE_RET(chip, ret) return(ret) > +#define TRACE_GOTO(chip, label) goto(label)
This will cause a compile error.
There is no need to do this, checkpatch.pl is wrong here.
regards, dan carpenter
| |