Messages in this thread | | | Date | Tue, 2 Oct 2012 12:47:07 +0100 | From | Alan Cox <> | Subject | Re: [PATCH v2] serial/arc-uart: Add new driver |
| |
> +/* Is this for UART emulation on ARC Instruction Set Simulator (ISS) > */ +int __attribute__((weak)) running_on_iss;
Why not pass a quirks field in your platform data instead - much cleaner than a global. > +static void arc_serial_set_ldisc(struct uart_port *port, int ld) > +{ > +}
If you don't need it just remove this one
> + new->c_cflag &= ~(CMSPAR|CRTSCTS);
also force the CSIZE bits to CS8 if you only do 8N1.
Alan
| |