Messages in this thread | | | Subject | Re: [PATCH] perf x86_64: Fix rsp register for system call fast path | From | Peter Zijlstra <> | Date | Tue, 02 Oct 2012 12:44:04 +0200 |
| |
On Mon, 2012-10-01 at 19:31 +0200, Jiri Olsa wrote: > @@ -696,7 +696,7 @@ struct perf_branch_stack { > > struct perf_regs_user { > __u64 abi; > - struct pt_regs *regs; > + struct pt_regs regs; > };
That's somewhat unfortunate but unavoidable I guess, can't go modify pt_regs.
> + if (uregs->abi) > + stack_size = perf_sample_ustack_size(sample_stack_user, > + header->size, > +
just a style nit, please add {} for all multi-line single stmt constructs like that, even though not strictly required.
It reduces the possible confusion between multi-line and multi-statement and reads easier.
| |