Messages in this thread | | | Date | Fri, 19 Oct 2012 12:36:00 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle |
| |
Hello, Vivek.
On Fri, Oct 19, 2012 at 11:00:11AM -0400, Vivek Goyal wrote: > > That way we can stick to the usual stats facility. > > So how does this help? Because it is a monotonically increasing value > we can use per cpu stats without extra locking? Or somthing else?
It's generally much simpler to expose dumb increasing counters. You don't have to worry about mismatching decrements (for whatever reason, percpu or segmented counters), so unless there's a pretty good reason to deviate, why deviate?
Thanks.
-- tejun
| |