lkml.org 
[lkml]   [2012]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 49/76] md/raid10: use correct limit variable
    Date
    3.6-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 91502f099dfc5a1e8812898e26ee280713e1d002 upstream.

    Clang complains that we are assigning a variable to itself. This should
    be using bad_sectors like the similar earlier check does.

    Bug has been present since 3.1-rc1. It is minor but could
    conceivably cause corruption or other bad behaviour.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: NeilBrown <neilb@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/md/raid10.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/md/raid10.c
    +++ b/drivers/md/raid10.c
    @@ -3158,7 +3158,7 @@ static sector_t sync_request(struct mdde
    else {
    bad_sectors -= (sector - first_bad);
    if (max_sync > bad_sectors)
    - max_sync = max_sync;
    + max_sync = bad_sectors;
    continue;
    }
    }



    \
     
     \ /
      Last update: 2012-10-19 06:21    [W:4.151 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site