lkml.org 
[lkml]   [2012]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 42/76] video/udlfb: fix line counting in fb_write
    Date
    3.6-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alexander Holler <holler@ahsoftware.de>

    commit b8c4321f3d194469007f5f5f2b34ec278c264a04 upstream.

    Line 0 and 1 were both written to line 0 (on the display) and all subsequent
    lines had an offset of -1. The result was that the last line on the display
    was never overwritten by writes to /dev/fbN.

    Signed-off-by: Alexander Holler <holler@ahsoftware.de>
    Acked-by: Bernie Thompson <bernie@plugable.com>
    Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/video/udlfb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/video/udlfb.c
    +++ b/drivers/video/udlfb.c
    @@ -647,7 +647,7 @@ static ssize_t dlfb_ops_write(struct fb_
    result = fb_sys_write(info, buf, count, ppos);

    if (result > 0) {
    - int start = max((int)(offset / info->fix.line_length) - 1, 0);
    + int start = max((int)(offset / info->fix.line_length), 0);
    int lines = min((u32)((result / info->fix.line_length) + 1),
    (u32)info->var.yres);




    \
     
     \ /
      Last update: 2012-10-19 05:41    [W:3.371 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site