Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 1/4] module: add syscall to load module from fd | Date | Fri, 19 Oct 2012 12:53:14 +1030 |
| |
"H. Peter Anvin" <hpa@zytor.com> writes: > Given that, I have to say I now seriously question the value of > finit_module(). The kernel can trivially discover if the pointed-to > memory area is a MAP_SHARED mmap() of a file descriptor and if so which > file descriptor... why can't we handle this behind the scenes?
It is a bit more indirect, but also in practice it's a bit trickier than that. We need to ensure the memory doesn't change underneath us and stays attached to that fd. I can easily see that code slipping and ending in an exploit.
But that may be my irrational fear of the mm :)
Cheers, Rusty.
| |