Messages in this thread | | | Date | Thu, 18 Oct 2012 15:46:06 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 4/6] cgroups: forbid pre_destroy callback to fail |
| |
On Thu, Oct 18, 2012 at 03:41:48PM -0700, Tejun Heo wrote: > Note that the patch is broken in a couple places but it does show the > general direction. I'd prefer if patch #3 simply makes pre_destroy() > return 0 and drop __DEPRECATED_clear_css_refs from mem_cgroup_subsys. > Then, I can pull the branch in and drop all the unnecessary cruft.
But you need the locking change for further memcg cleanup. To avoid interlocked pulls from both sides, I think it's okay to push this one with the rest of memcg changes. I can do the cleanup on top of this whole series, but please do drop .__DEPRECATED_clear_css_refs from memcg.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |