lkml.org 
[lkml]   [2012]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/4] thp: introduce hugepage_get_pmd()
On Thu, 18 Oct 2012, Bob Liu wrote:

> Introduce hugepage_get_pmd() to simple code.
>

I don't see this as simple just because you're removing more lines, I find
pagetable walks to be harder to read when split up like this and the "get"
part implies you're grabbing a reference on the pmd, which you're not.


\
 
 \ /
  Last update: 2012-10-18 23:01    [W:0.050 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site