Messages in this thread | | | Subject | Re: [PATCH 1/6] mmc: core: sdio_io.c: Fixed lines with > 80 chars | From | Joe Perches <> | Date | Thu, 18 Oct 2012 09:47:29 -0700 |
| |
On Fri, 2012-10-19 at 01:31 +0900, Sangho Yi wrote: > I fixed lines over 80 characters per line.
If you really must do these things, please use checkpatch.pl --strict for guidance on how to align function arguments.
> diff --git a/drivers/mmc/core/sdio_io.c b/drivers/mmc/core/sdio_io.c [] > @@ -664,7 +665,8 @@ void sdio_f0_writeb(struct sdio_func *func, unsigned char b, unsigned int addr, > > BUG_ON(!func); > > - if ((addr < 0xF0 || addr > 0xFF) && (!mmc_card_lenient_fn0(func->card))) { > + if ((addr < 0xF0 || addr > 0xFF) && > + (!mmc_card_lenient_fn0(func->card))) {
ugly alignment and unnecessary parenthesis too.
| |