Messages in this thread | | | Subject | Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings. | From | Ian Campbell <> | Date | Thu, 18 Oct 2012 14:33:29 +0100 |
| |
On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote: > On Wed, 17 Oct 2012, Ian Campbell wrote: > > We use XENMEM_add_to_physmap_range which is the preferred interface > > for foreign mappings. > > > > Signed-off-by: Ian Campbell <ian.campbell@citrix.com> > > It looks OK but there are few code style issues, please run the patch > through checkpatch.
The only one I get is: WARNING: please, no spaces at the start of a line #83: FILE: include/xen/interface/memory.h:175: + uint16_t size;$
total: 0 errors, 1 warnings, 64 lines checked
The prevailing indentation in that file is 4 spaces so I think we should ignore the warning in this case in the interests of consistency with the surrounding code.
Ian.
| |