lkml.org 
[lkml]   [2012]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.
From
Date
On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote:
> On Wed, 17 Oct 2012, Ian Campbell wrote:
> > We use XENMEM_add_to_physmap_range which is the preferred interface
> > for foreign mappings.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>
> It looks OK but there are few code style issues, please run the patch
> through checkpatch.

The only one I get is:
WARNING: please, no spaces at the start of a line
#83: FILE: include/xen/interface/memory.h:175:
+ uint16_t size;$

total: 0 errors, 1 warnings, 64 lines checked

The prevailing indentation in that file is 4 spaces so I think we should
ignore the warning in this case in the interests of consistency with the
surrounding code.

Ian.




\
 
 \ /
  Last update: 2012-10-18 16:21    [W:0.121 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site