Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk | Date | Wed, 17 Oct 2012 10:49:10 +0900 |
| |
On Wednesday, October 17, 2012 2:33 AM Linus Walleij wrote: > > On Tue, Oct 16, 2012 at 10:25 AM, Jingoo Han <jg1.han@samsung.com> wrote: > > > int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip, > > unsigned int off, samsung_gpio_pull_t pull) > > { > > @@ -599,7 +593,7 @@ static int samsung_gpiolib_4bit_input(struct gpio_chip *chip, > > con &= ~(0xf << con_4bit_shift(offset)); > > __raw_writel(con, base + GPIOCON_OFF); > > > > - gpio_dbg("%s: %p: CON now %08lx\n", __func__, base, con); > > + pr_debug("%s: %p: CON now %08lx\n", __func__, base, con); > > Does your struct gpio_chip provide a valid dev pointer so you can use: > > dev_dbg(chip->dev, "%s: %p: CON now %08lx\n", __func__, base, con); > > In that case use the dev_* print macros everywhere instead. >
No, a valid dev pointer is not provided yet. After a valid dev pointer is available, I will change pr_debug to dev_dbg.
Best regards, Jingoo Han
> Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |