Messages in this thread | | | Date | Mon, 15 Oct 2012 16:15:58 +0800 | Subject | Re: [RFC v3 12/13] vfs: add debugfs support | From | Zhi Yong Wu <> |
| |
On Mon, Oct 15, 2012 at 3:55 PM, Dave Chinner <david@fromorbit.com> wrote: > On Wed, Oct 10, 2012 at 06:07:34PM +0800, zwu.kernel@gmail.com wrote: >> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com> >> >> Add a /sys/kernel/debug/hot_track/<device_name>/ directory for each >> volume that contains two files. The first, `inode_data', contains the >> heat information for inodes that have been brought into the hot data map >> structures. The second, `range_data', contains similar information for >> subfile ranges. > .... >> + /* create debugfs range_data file */ >> + debugfs_range_entry = debugfs_create_file("range_data", >> + S_IFREG | S_IRUSR | S_IWUSR | S_IRUGO, >> + debugfs_volume_entry, >> + (void *) range_data, >> + &hot_debugfs_range_fops); > > These should not be world readable. 0600 is probably the correct > permissions for them as we do not want random users to be able to > infer what files users are accessing from this information. Good catch, its mode should be S_IFREG | S_IRUSR | S_IWUSR
> > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com
-- Regards,
Zhi Yong Wu
| |