lkml.org 
[lkml]   [2012]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 027/147] [media] rc: ite-cir: Initialise ite_dev::rdev earlier
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Ben Hutchings <ben@decadent.org.uk>

    commit 4b961180ef275035b1538317ffd0e21e80e63e77 upstream.

    ite_dev::rdev is currently initialised in ite_probe() after
    rc_register_device() returns. If a newly registered device is opened
    quickly enough, we may enable interrupts and try to use ite_dev::rdev
    before it has been initialised. Move it up to the earliest point we
    can, right after calling rc_allocate_device().

    Reported-and-tested-by: YunQiang Su <wzssyqa@gmail.com>

    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    ---
    drivers/media/rc/ite-cir.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c
    index 36fe5a3..24c77a4 100644
    --- a/drivers/media/rc/ite-cir.c
    +++ b/drivers/media/rc/ite-cir.c
    @@ -1473,6 +1473,7 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
    rdev = rc_allocate_device();
    if (!rdev)
    goto failure;
    + itdev->rdev = rdev;

    ret = -ENODEV;

    @@ -1604,7 +1605,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
    if (ret)
    goto failure;

    - itdev->rdev = rdev;
    ite_pr(KERN_NOTICE, "driver has been successfully loaded\n");

    return 0;



    \
     
     \ /
      Last update: 2012-10-14 17:21    [W:2.917 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site