lkml.org 
[lkml]   [2012]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 063/147] ext4: online defrag is not supported for journaled files
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dmitry Monakhov <dmonakhov@openvz.org>

    commit f066055a3449f0e5b0ae4f3ceab4445bead47638 upstream.

    Proper block swap for inodes with full journaling enabled is
    truly non obvious task. In order to be on a safe side let's
    explicitly disable it for now.

    Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/ext4/move_extent.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
    index df5cde5..e2016f3 100644
    --- a/fs/ext4/move_extent.c
    +++ b/fs/ext4/move_extent.c
    @@ -1142,7 +1142,12 @@ ext4_move_extents(struct file *o_filp, struct file *d_filp,
    orig_inode->i_ino, donor_inode->i_ino);
    return -EINVAL;
    }
    -
    + /* TODO: This is non obvious task to swap blocks for inodes with full
    + jornaling enabled */
    + if (ext4_should_journal_data(orig_inode) ||
    + ext4_should_journal_data(donor_inode)) {
    + return -EINVAL;
    + }
    /* Protect orig and donor inodes against a truncate */
    mext_inode_double_lock(orig_inode, donor_inode);




    \
     
     \ /
      Last update: 2012-10-14 17:21    [W:6.757 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site