Messages in this thread | | | Date | Sun, 14 Oct 2012 06:07:57 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Drivers: Staging: CSR: Fixed coding style warnings |
| |
On Sun, Oct 14, 2012 at 09:48:29PM +0900, Sangho Yi wrote: > On drivers/staging/csr/csr_time.h, there were a few warnings on > indentation, braces, and typedef struct usage. > All those were changed to the proper way.
No, as I explained in the talk, only do one thing at a time here.
So, one patch for the indentation, one patch for the braces, and then, one patch for the typedef.
And, with the typedef change, did you just break the build? If not, then the whole structure can be removed, right?
So, care to redo this?
thanks,
greg k-h
| |