lkml.org 
[lkml]   [2012]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Drivers: Staging: CSR: made corrections on the indentation errors
On Sun, Oct 14, 2012 at 08:20:11PM +0900, Sangho Yi wrote:
> Originally there were a lot mis-indentation, so I made changes to use
> only the tabs (no spaces) on indenting code.
> - Still, the typedef struct ... tells warning message on checkpatch.pl.

Yes, we shouldn't be using a typedef, but why did you change the typedef
itself:

> -typedef struct
> -{
> - u32 sec;
> - u16 msec;
> +typedef struct _CsrTimeUtc {
> + u32 sec;
> + u16 msec;
> } CsrTimeUtc;

Why add the _CsrTimeUtc here? That's not really needed, right?

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-10-14 14:01    [W:0.061 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site