Messages in this thread | | | Date | Sun, 14 Oct 2012 12:28:20 +0200 | From | Marco Stornelli <> | Subject | Re: [PATCH 06/22] ocfs2: drop vmtruncate |
| |
Il 13/10/2012 18:19, Christoph Hellwig ha scritto: >> if ((attr->ia_valid & ATTR_SIZE) && >> attr->ia_size != i_size_read(inode)) { >> - status = vmtruncate(inode, attr->ia_size); >> + status = inode_newsize_ok(inode, attr->ia_size); >> if (status) { >> mlog_errno(status); >> goto bail_commit; >> } >> + truncate_setsize(inode, attr->ia_size); > > ocfs2 already calls inode_newsize_ok earlier during ocfs2_setattr, > and there's an XXX comment just above the vmtruncate call about > how ocfs2 hacks around this. I suspect you just want a plain > truncate_setsize here and remove the comment above it, but I'd > like to have the ocfs2 folks confirm that. > >
Yep, I quite agree. truncate_setsize can be moved up into to the previous "if (size_change && attr->ia_size != i_size_read(inode))" where the truncate code does its work.
| |