lkml.org 
[lkml]   [2012]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/22] ocfs2: drop vmtruncate
Il 13/10/2012 18:19, Christoph Hellwig ha scritto:
>> if ((attr->ia_valid & ATTR_SIZE) &&
>> attr->ia_size != i_size_read(inode)) {
>> - status = vmtruncate(inode, attr->ia_size);
>> + status = inode_newsize_ok(inode, attr->ia_size);
>> if (status) {
>> mlog_errno(status);
>> goto bail_commit;
>> }
>> + truncate_setsize(inode, attr->ia_size);
>
> ocfs2 already calls inode_newsize_ok earlier during ocfs2_setattr,
> and there's an XXX comment just above the vmtruncate call about
> how ocfs2 hacks around this. I suspect you just want a plain
> truncate_setsize here and remove the comment above it, but I'd
> like to have the ocfs2 folks confirm that.
>
>

Yep, I quite agree. truncate_setsize can be moved up into to the
previous "if (size_change && attr->ia_size != i_size_read(inode))" where
the truncate code does its work.


\
 
 \ /
  Last update: 2012-10-14 13:21    [W:0.065 / U:2.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site