lkml.org 
[lkml]   [2012]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/22] hostfs: drop vmtruncate
> +++ b/fs/hostfs/hostfs_kern.c
> @@ -848,9 +848,11 @@ int hostfs_setattr(struct dentry *dentry, struct iattr *attr)
> attr->ia_size != i_size_read(inode)) {
> int error;
>
> - error = vmtruncate(inode, attr->ia_size);
> - if (err)
> - return err;
> + error = inode_newsize_ok(inode, attr->ia_size);
> + if (error)
> + return error;
> +
> + truncate_setsize(inode, attr->ia_size);

The inode_change_ok call here is superflous, it's already done by
inode_change_ok at the beginning of the function. Even if that wasn't
done doing it aftet set_attr() would be too late anyway.



\
 
 \ /
  Last update: 2012-10-13 19:01    [W:0.051 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site