lkml.org 
[lkml]   [2012]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Spurious warning in checkpatch.pl?
From
Date
On Fri, 2012-10-12 at 13:23 -0500, Larry Finger wrote:
> Andy,
>
> The checkpatch.pl version in mainline is issuing what I think are false warnings
> of the type
>
> WARNING: networking block comments put the trailing */ on a separate line
> #93: FILE: drivers/net/wireless/rtlwifi/wifi.h:208:
> + u32 rf_rb; /* rflssi_readback */
>
> Is a trailing comment for the member of a struct not allowed?

It's allowed. Maybe even better, encouraged.

It's a change I made in commit 058806007450
("checkpatch: check networking specific block comment style")
without sufficient testing.

I'll see about fixing it.




\
 
 \ /
  Last update: 2012-10-12 21:21    [W:0.502 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site