Messages in this thread | | | Date | Fri, 12 Oct 2012 20:17:49 +0530 | Subject | Re: [PATCH 2/3] dmaengine: dw_dmac: Enhance device tree support | From | Viresh Kumar <> |
| |
On 12 October 2012 20:11, Shevchenko, Andriy <andriy.shevchenko@intel.com> wrote: > On Fri, 2012-10-12 at 19:36 +0530, Viresh Kumar wrote: > I meant is to use that constant instead of hard coding 4 everywhere. > It's a maximum value, not the SoC specific.
Can be done.
>> + u32 val, arr[4]; > what about to use tmp name instead of val? It's really minor, but I > think val name is little bit unrelated to a loop counter.
Its not minor at all, its major. Even when i was coding it, i thought about renaming it several times during this last patch. But couldn't find a better name.
I don't like tmp. Give me something better.
viresh
| |