Messages in this thread | | | Date | Thu, 11 Oct 2012 14:53:10 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH v4 04/14] kmem accounting basic infrastructure |
| |
On Thu 11-10-12 12:11:19, Michal Hocko wrote: > On Mon 08-10-12 14:06:10, Glauber Costa wrote: [...] > > +static void memcg_kmem_set_active(struct mem_cgroup *memcg) > > +{ > > + set_bit(KMEM_ACCOUNTED_ACTIVE, &memcg->kmem_accounted); > > +} > > + > > +static bool memcg_kmem_is_accounted(struct mem_cgroup *memcg) > > +{ > > + return test_bit(KMEM_ACCOUNTED_ACTIVE, &memcg->kmem_accounted); > > +} > > +#endif > > set_active vs. is_accounted. Is there any reason for inconsistency here?
Ahh, fixed later and 09/14 makes it memcg_kmem_is_active so this is just a code churn. I think making it memcg_kmem_is_active here would be better.
-- Michal Hocko SUSE Labs
| |