lkml.org 
[lkml]   [2012]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 02/84] kbuild: make: fix if_changed when command contains backslashes
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Sascha Hauer <s.hauer@pengutronix.de>

    commit c353acba28fb3fa1fd05fd6b85a9fc7938330f9c upstream.

    The call if_changed mechanism does not work when the command contains
    backslashes. This basically is an issue with lzo and bzip2 compressed
    kernels. The compressed binaries do not contain the uncompressed image
    size, so these use size_append to append the size. This results in
    backslashes in the executed command. With this if_changed always
    detects a change in the command and rebuilds the compressed image even
    if nothing has changed.

    Fix this by escaping backslashes in make-cmd

    Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
    Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
    Cc: Sam Ravnborg <sam@ravnborg.org>
    Cc: Bernhard Walle <bernhard@bwalle.de>
    Cc: Michal Marek <mmarek@suse.cz>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    scripts/Kbuild.include | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/scripts/Kbuild.include
    +++ b/scripts/Kbuild.include
    @@ -205,7 +205,7 @@ endif
    # >$< substitution to preserve $ when reloading .cmd file
    # note: when using inline perl scripts [perl -e '...$$t=1;...']
    # in $(cmd_xxx) double $$ your perl vars
    -make-cmd = $(subst \#,\\\#,$(subst $$,$$$$,$(call escsq,$(cmd_$(1)))))
    +make-cmd = $(subst \\,\\\\,$(subst \#,\\\#,$(subst $$,$$$$,$(call escsq,$(cmd_$(1))))))

    # Find any prerequisites that is newer than target or that does not exist.
    # PHONY targets skipped in both cases.



    \
     
     \ /
      Last update: 2012-10-11 05:01    [W:4.210 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site