lkml.org 
[lkml]   [2012]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch for-linus] memcg, kmem: fix build error when CONFIG_INET is disabled
On Wed 10-10-12 12:56:26, Glauber Costa wrote:
> On 10/10/2012 10:32 AM, David Rientjes wrote:
> > Commit e1aab161e013 ("socket: initial cgroup code.") causes a build error
> > when CONFIG_INET is disabled in Linus' tree:
> >
> unlikely that something that old would cause a build bug now, specially
> that commit, that actually wraps things inside CONFIG_INET.
>
> More likely caused by the recently merged
> "memcg-cleanup-kmem-tcp-ifdefs.patch" in -mm by mhocko (CC'd)

Strange it didn't trigger during my (and Fenguang) build testing.

> As a matter of fact, I just tested, and it indeed start failing after
> that patch.
>
> Michal, since it is just a cleanup patch, I'd prefer just reverting if
> you are okay with it.

I think that taking David's patch makes more sense.

--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2012-10-10 12:01    [W:0.074 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site