lkml.org 
[lkml]   [2012]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/4 v2] irqdomain: augment add_simple() to allocate descs
From
On Mon, Oct 1, 2012 at 2:11 PM, Rob Herring <robherring2@gmail.com> wrote:
> On 10/01/2012 02:35 AM, Linus Walleij wrote:
>> From: Linus Walleij <linus.walleij@linaro.org>
>>
>> Currently we rely on all IRQ chip instances to dynamically
>> allocate their IRQ descriptors unless they use the linear
>> IRQ domain. So for irqdomain_add_legacy() and
>> irqdomain_add_simple() the caller need to make sure that
>> descriptors are allocated.
>>
>> Let's slightly augment the yet unused irqdomain_add_simple()
>> to also allocate descriptors as a means to simplify usage
>> and avoid code duplication throughout the kernel.
>>
>> We warn if descriptors cannot be allocated, e.g. if a
>> platform has the bad habit of hogging descriptors at boot
>> time.
>>
>> Cc: Rob Herring <rob.herring@calxeda.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Paul Mundt <lethal@linux-sh.org>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Looks good.
>
> Reviewed-by: Rob Herring <rob.herring@calxeda.com>

So what do we do with this patch? Grant?

I think the change is good to get in ASAP and since I
now have one patch in pinctrl depending on it I have
tentatively applied it there.

Nobody sent any irqdomain fixes for this merge
window, maybe this is the only relevant patch...

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2012-10-10 09:21    [W:0.245 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site