lkml.org 
[lkml]   [2012]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: thp: Set the accessed flag for old pages on access fault.
On Mon, Oct 01, 2012 at 02:51:45PM +0100, Will Deacon wrote:
> diff --git a/mm/memory.c b/mm/memory.c
> index 5736170..d5c007d 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3537,7 +3537,11 @@ retry:
> if (unlikely(ret & VM_FAULT_OOM))
> goto retry;
> return ret;
> + } else {
> + huge_pmd_set_accessed(mm, vma, address, pmd,
> + orig_pmd);

I think putting it to 'else' is wrong. You should not touch pmd, if it's
under splitting.

> }
> +
> return 0;
> }
> }

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2012-10-01 16:41    [W:0.143 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site