Messages in this thread | | | Date | Mon, 1 Oct 2012 17:03:05 +0300 | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH] mm: thp: Set the accessed flag for old pages on access fault. |
| |
On Mon, Oct 01, 2012 at 02:51:45PM +0100, Will Deacon wrote: > diff --git a/mm/memory.c b/mm/memory.c > index 5736170..d5c007d 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -3537,7 +3537,11 @@ retry: > if (unlikely(ret & VM_FAULT_OOM)) > goto retry; > return ret; > + } else { > + huge_pmd_set_accessed(mm, vma, address, pmd, > + orig_pmd);
I think putting it to 'else' is wrong. You should not touch pmd, if it's under splitting.
> } > + > return 0; > } > }
-- Kirill A. Shutemov
| |