[lkml]   [2012]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: Incorrect uses of get_driver()/put_driver()
On Mon, 9 Jan 2012 14:48:15 -0500 (EST)
Alan Stern <> wrote:

> Maybe you want to call device_lock(&sdev->dev) here? It will prevent
> the driver from being unbound (and therefore from being unloaded), and
> it's likely that sdrv's remove and probe routines expect to be called
> with this lock held, because that's what the device core does. The
> drawback is that holding the lock prevents other things from happening
> as well, like unregistering sdev.
> Alternatively, we can simply remove ssb_driver_get/put.

I think in practice it doesn't matter. This function is only
used in the rare case where the EEPROM on the board is written.

Greetings, Michael.

 \ /
  Last update: 2012-01-09 21:11    [W:0.062 / U:0.064 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site