[lkml]   [2012]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: Incorrect uses of get_driver()/put_driver()
    On Mon, Jan 09, 2012 at 12:35:09PM -0500, Alan Stern wrote:
    > lib/dma-debug.c:173: drv = get_driver(dev->driver);
    > lib/dma-debug.c:188: put_driver(drv);
    > Joerg, these calls don't seem to do anything, as far as I can tell.
    > Is there any reason to keep them?

    No reason to keep them :) It can be replaced with dev->driver, even
    reference counting is not needed because only the pointer is kept and
    never dereferenced.


    AMD Operating System Research Center

    Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
    General Managers: Alberto Bozzo, Andrew Bowd
    Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

     \ /
      Last update: 2012-01-09 19:07    [W:0.021 / U:1.172 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site