Messages in this thread | | | From | Linus Torvalds <> | Date | Fri, 6 Jan 2012 09:04:56 -0800 | Subject | Re: Broken ioctl error returns (was Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices) |
| |
On Fri, Jan 6, 2012 at 8:19 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > For a simpler solution, we could keep the old warning message, but change > the logic from > > (.compat_ioctl == NULL || .compat_ioctl() == -ENOIOCTL) && (no generic handler) > > to > > (.ioctl != NULL && .compat_ioctl == NULL) && (no generic handler). > > and then fix the warnings we see by adding appropriate .compat_ioctl > functions.
So I have no problem with that. What I did have problems with was the net/socket.c kind of workarounds (which I noticed mainly because they had that whole EINVAL confusion built into them). Those were why I decided that the warning has to go.
But if you can re-introduce the warning without workarounds like those, I have no problem with us reintroducing the warning, even if it is technically not really kosher and will afaik still print that warning for the case of a compat-ioctl transform that *would* have been valid, just not for that particular file descriptor.
But the printout is small and not all that annoying, and explicitly limited in number, so I guess I don't mind a few false positives if it really can help find stale translation entries.
Linus
| |