Messages in this thread | | | Date | Fri, 06 Jan 2012 15:50:04 +0000 | Subject | Re: [Xen-devel] [PATCH 4/5] xen/pciback: Expand the warning message to include domain id. | From | Keir Fraser <> |
| |
On 06/01/2012 15:03, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com> wrote:
>> As you're touching this anyway, how about fixing the other minor >> issues with it too? E.g. >> >> dev_err(&dev->dev, "Device appears to be assigned to dom%d!" >> " Overwriting the ownership, but beware.\n", >> xen_find_device_domain_owner(dev)); >> >> (a native English speaker may want to comment the "but beware" >> part - it reads odd for me). > > Hm, lets ask the English speakers. Ian?
The suggested reworking above is an improvement. The "but beware" bit is fine.
-- keir
| |