lkml.org 
[lkml]   [2012]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] time: remove the unnecessary CONFIG_GENERIC_CLOCKEVENS check
Hi Paul, 

On Thu, Jan 05, 2012 at 12:17:46PM +0100, Paul Bolle wrote:
> On Thu, 2012-01-05 at 21:28 +0800, Feng Tang wrote:
> > In kernel/time/Kconfig:
> > config GENERIC_CLOCKEVENTS_BUILD
> > bool
> > default y
> > depends on GENERIC_CLOCKEVENTS
> >
> > So there is no need to check CONFIG_GENERIC_CLOCKEVENTS if the
> > CONFIG_GENERIC_CLOCKEVENTS_BUILD is defined already.
>
> This is only true because nothing selects GENERIC_CLOCKEVENTS_BUILD
> directly, isn't it?

Thanks for pointing this out, your concern is valid, even though there
will be a warning message about the dependency corruption if the
GENERIC_CLOCKEVENTS_BUILD is directly selected while the
GENERIC_CLOCKEVENTS is N.

Thanks,
Feng

> So if we're being strict the patch explanation
> should mention that.
>
> (Maybe it's even better to simply state
> There is no need to check CONFIG_GENERIC_CLOCKEVENTS if
> CONFIG_GENERIC_CLOCKEVENTS_BUILD is defined.
>
> This prepares [...]
>
> as that would tell us just enough.)
>
> > This prepares for the total removal of GENERIC_CLOCKEVENTS_BUILD.
>
>
> Paul Bolle


\
 
 \ /
  Last update: 2012-01-06 03:15    [from the cache]
©2003-2011 Jasper Spaans