Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 5 Jan 2012 08:16:06 -0800 | Subject | Re: [PATCH 2/3] block: fail SCSI passthrough ioctls on partition devices |
| |
On Thu, Jan 5, 2012 at 5:18 AM, Paolo Bonzini <pbonzini@redhat.com> wrote: > > Hence, changing scsi_verify_blk_ioctl to return ENOIOCTLCMD is not > really possible.
What?
"We have a bug in the block IO layer, so we cannot possible fix another problem?"
Whjat the f*ck is the logic there?
Just fix the *obvious* breakage in BLKROSET. It's clearly what the code *intends* to do, it just didn't check for ENOIOCTLCMD.
In fact, fixing that BLKROSET case would make it much more obvious *why* it has those error tests at all. And we really should try to just remove the crazy EINVAL case, because it really is wrong - and then fix any broken drivers that exposes.
It's a DISEASE how you seem to think that "we have ugly mistakes in the kernel, SO LET'S ADD ANOTHER ONE".
That's not how we do things. We *fix* things, instead of making things even *worse*.
Stop this insanity from spreading, instead of making it spread more!
Linus
| |