lkml.org 
[lkml]   [2012]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/7] amp/remoteproc: add framework for controlling remote processors
On Wed, Jan 4, 2012 at 1:35 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
>> +     /* go through the available ELF segments */
>> +     for (i = 0; i < ehdr->e_phnum; i++, phdr++) {
>> +             u32 da = phdr->p_paddr;
>> +             u32 memsz = phdr->p_memsz;
>> +             u32 filesz = phdr->p_filesz;
>
> This could be an endianess problem.  If the endianess of the host and
> the rproc are different, then what is the endianess of the elf file?
> Is the endianess of the elf file verified before attempting to parse it?
...
> Nitpick: A look up table would be easier to extend in the future.
>
> Otherwise;
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>

Thanks, Grant!

If I may, I'll add something like this to the commit log:

Acked-by: Grant Likely <grant.likely@secretlab.ca> (minus two
Reported-by issues)

And then we could fix those two issues in two subsequent patches
(carrying your Reported-by) so reviewing the change would be much
easier, and we don't end up changing code (that has been lying in
linux-next) just before it is sent it to Linus.

Thanks a lot for your review!
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-01-05 15:01    [W:0.123 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site