Messages in this thread | | | Date | Wed, 4 Jan 2012 10:01:03 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH 2/2] memcg: mark rcu protected member as __rcu |
| |
On Tue 03-01-12 18:33:52, kosaki.motohiro@gmail.com wrote: > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Currently "make C=2 mm/memcontrol.o" makes following warnings. fix it. > > mm/memcontrol.c:4243:21: error: incompatible types in comparison expression (different address spaces) > mm/memcontrol.c:4245:21: error: incompatible types in comparison expression (different address spaces) > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: cgroups@vger.kernel.org
Looks correct.
Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks
> --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6adeeec..138be2b 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -195,7 +195,7 @@ struct mem_cgroup_threshold_ary { > > struct mem_cgroup_thresholds { > /* Primary thresholds array */ > - struct mem_cgroup_threshold_ary *primary; > + struct mem_cgroup_threshold_ary __rcu *primary; > /* > * Spare threshold array. > * This is needed to make mem_cgroup_unregister_event() "never fail". > -- > 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe cgroups" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
-- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech Republic
| |