Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [RFC][PATCH] tracing/module: Move tracepoint out of module.h | Date | Wed, 01 Feb 2012 11:40:22 +1030 |
| |
On Tue, 31 Jan 2012 13:20:16 +0100, Ingo Molnar <mingo@elte.hu> wrote: > > Wow, we're really bikeshedding this! > > Hey, I don't think this is bikesheddig: we are shedding > *kilobytes* of code from pretty hot codepaths, that kind of > topic does deserve some detailed attention :-)
I agree, but we put the bloat in without this much discussion :)
I get the impression last I looked that most get/put aren't actually hot paths (though it was designed to allow that, such as an inc per packet). Which is an even better reason to out-of-line it...
> > Doesn't save me much here, though. What are your stats? > > I suspect it depends on inlining options in the .config plus on > event tracing? ... > Most distro kernels do tracepoints so I guess that's where the > size delta comes from :-) In any case: >
Yeah, I'm rebuilding an Ubuntu config kernel before and after to get some more accurate stats on the final result for the commit message.
> Acked-by: Ingo Molnar <mingo@elte.hu>
Thanks, Rusty.
| |