lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] coda: Remove unnecessary OOM messages
From
Date
On Tue, 2012-01-31 at 22:10 -0500, Jan Harkes wrote:
> Joe Perches <joe@perches.com> wrote:
> >On Wed, 2012-02-01 at 11:23 +1100, Ryan Mallon wrote:
> >> On 01/02/12 11:21, Joe Perches wrote:
> >> > Maybe because alloc/free functions are
> >> > used relatively infrequently, maybe it'd
> >> > be better to not declare the functions
> >> > inline but add them to coda_linux.c
> >> Sure, either approach is fine. Do you want to add the patch to your
> >series?
> >I think Jan can work it out properly if he wants it.
> It looks good to me, I have no problem if you want to add it to your series.

(adding Al Viro and Andrew Morton to cc:)

Hi Jan.

I think Ryan's patches are fine as well.

From my perspective as a contributor, you should ack the
patches you apply to your own tree with your own
"Signed-off-by:" tag and later send a pull request to
Linus or another upstream maintainer like Al Viro or you
should ack the patches and forward them to another upstream
maintainer to be applied in their tree with your "Acked-by:"
tag.

cheers, Joe



\
 
 \ /
  Last update: 2012-02-01 04:45    [from the cache]
©2003-2011 Jasper Spaans