Messages in this thread | | | Date | Wed, 01 Feb 2012 11:23:08 +1100 | From | Ryan Mallon <> | Subject | Re: [PATCH 1/4] coda: Remove unnecessary OOM messages |
| |
On 01/02/12 11:21, Joe Perches wrote:
>> Since CODA_ALLOC no longer uses __FILE__ and __LINE__ and doesn't use >> the cast argument any more, it can be replaced with a static inline >> function. Something like this (untested, applies on top of your patch): > > Hi Ryan. > > I didn't want to be quite so invasive > but this looks like a nice cleanup to me.
Yeah, it needed to be done as a separate patch. Just a good time to do it now that it no longer needs to be a macro.
> Maybe because alloc/free functions are > used relatively infrequently, maybe it'd > be better to not declare the functions > inline but add them to coda_linux.c
Sure, either approach is fine. Do you want to add the patch to your series?
~Ryan
> >> +static inline void *coda_alloc(size_t size) >> +{ >> + if (size < PAGE_SIZE) >> + return kzalloc(size, GFP_KERNEL); >> + return vzalloc(size); >> +} > [] >> +static inline void coda_free(const void *ptr, size_t size) >> +{ >> + if (size < PAGE_SIZE) >> + kfree(ptr); >> + else >> + vfree(ptr); >> +} > >
| |