Messages in this thread | | | From | Grant Likely <> | Date | Tue, 31 Jan 2012 14:52:55 -0700 | Subject | Re: [PATCH 1/3] platform: add common resource requesting and mapping helper |
| |
On Tue, Jan 31, 2012 at 2:20 PM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Tue, Jan 31, 2012 at 11:00 AM, Barry Song <Barry.Song@csr.com> wrote: > >> From: Barry Song <Baohua.Song@csr.com> >> >> this patch helps to move the common pattern from > > Good idea! > >> @@ -44,6 +44,7 @@ extern struct device platform_bus; >> >> extern void arch_setup_pdev_archdata(struct platform_device *); >> extern struct resource *platform_get_resource(struct platform_device *, unsigned int, unsigned int); >> +extern void __iomem *platform_devm_request_and_ioremap(struct platform_device *, unsigned int); > > But don't you want a reverse call for the module remove() function? > > Like: > > extern void __iomem *platform_devm_iounmap_and_free(struct > platform_device *, unsigned int);
I wouldn't because it is exactly the same as the normal unwind call. I don't think the name redirection buys us anything here.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |