Messages in this thread | | | Date | Tue, 31 Jan 2012 12:36:12 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] speed up /proc/pid/stat, statm |
| |
On Tue, 31 Jan 2012 17:14:43 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> +int seq_put_decimal_ll(struct seq_file *m, char delimiter, > + long long num) > +{ > + if (num < 0) { > + if (m->count + 3 >= m->size) { > + m->count = m->size;
Why is m->count udpated even thought we didn't write any data? seq_put_decimal_ull() does it too.
> + return -1; > + } > + if (delimiter) > + m->buf[m->count++] = delimiter; > + num = -num; > + delimiter = '-'; > + } > + return seq_put_decimal_ull(m, delimiter, num); > + > +} > +EXPORT_SYMBOL(seq_put_decimal_ll);
| |