lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 0/3] platform: add platform_devm_request_and_ioremap() common API
    Hi Artem,

    2012/1/31 Artem Bityutskiy <dedekind1@gmail.com>:
    > On Tue, 2012-01-31 at 17:59 +0800, Barry Song wrote:
    >> these patches move the common pattern from
    >>
    >> "
    >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    >> if (!res) {
    >>               ret = -ENODEV;
    >>                       goto err;
    >> }
    >>
    >> base = devm_request_and_ioremap(&dev->dev, mem_res);
    >> if (!base) {
    >>               ret = -ENODEV;
    >>                       goto err;
    >> }
    >> "
    >
    > Am I right that these patches have been generated using the
    > coccinelle/api/devm_request_and_ioremap.cocci script?
    >
    > If yes, I think it would be nice of you to give a credit to coccinelle
    > and its authors for developing this awesome tool in every commit
    > message.

    devm_request_and_ioremap() is still something new by commit
    72f8c0bfa0de64c68ee59f40eb9b2683bffffbb0:
    author Wolfram Sang <w.sang@pengutronix.de>
    Tue, 25 Oct 2011 13:16:47 +0000 (15:16 +0200)
    there are only a few users until now. but it is going to be used as a
    common/suggested way to request and map resource. now we don't need a
    script to find them, just cscope "cs f c devm_request_and_ioremap".

    >
    > --
    > Best Regards,
    > Artem Bityutskiy

    -barry
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-31 13:59    [from the cache]
    ©2003-2011 Jasper Spaans