lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix readahead pipeline break caused by block plug
On Tue, Jan 31, 2012 at 06:57:16AM -0500, Christoph Hellwig wrote:
> On Tue, Jan 31, 2012 at 07:42:56PM +0800, Wu Fengguang wrote:
> > > So what? Better do a bit more work now and keep the damn thing
> > > maintainable.
> >
> > What if we add a wrapper function for doing
> >
> > blk_start_plug(&plug);
> > ->direct_IO()
> > blk_finish_plug(&plug);
>
> No. Just put it into __blockdev_direct_IO - a quick 2 minute audit of
> the kernel source shows that is in fact the only ->direct_IO instance
> which ever submits block I/O anyway.

Right, so nice point!

Thanks,
Fengguang


\
 
 \ /
  Last update: 2012-01-31 13:33    [W:0.040 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site