lkml.org 
[lkml]   [2012]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: sched: fix compilation warning on !SMP
    From
    On 31 January 2012 09:46, Vincent Guittot <vincent.guittot@linaro.org> wrote:
    > 2012/1/31 Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>:
    >> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
    >>
    >>  CC      kernel/sched/fair.o
    >> kernel/sched/fair.c:218:36: warning: 'max_load_balance_interval' defined but not used [-Wunused-variable]
    >>
    >> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
    >> CC: Peter Zijlstra <a.p.zijlstra@chello.nl>
    >> CC: Vincent Guittot <vincent.guittot@linaro.org>
    >> ---
    >>  kernel/sched/fair.c |    4 ++--
    >>  1 files changed, 2 insertions(+), 2 deletions(-)
    >>
    >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    >> index 8e77a6b..4ab60a2 100644
    >> --- a/kernel/sched/fair.c
    >> +++ b/kernel/sched/fair.c
    >> @@ -215,8 +215,6 @@ calc_delta_mine(unsigned long delta_exec, unsigned long weight,
    >>
    >>  const struct sched_class fair_sched_class;
    >>
    >> -static unsigned long __read_mostly max_load_balance_interval = HZ/10;
    >> -
    >>  /**************************************************************
    >>  * CFS operations on generic schedulable entities:
    >>  */
    >> @@ -3086,6 +3084,8 @@ static bool yield_to_task_fair(struct rq *rq, struct task_struct *p, bool preemp
    >>  * Fair scheduling class load-balancing methods:
    >>  */
    >>
    >> +static unsigned long __read_mostly max_load_balance_interval = HZ/10;
    >> +
    >
    > Sorry for moving it out of SMP. Thanks for fixing this
    >

    Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>

    >>  /*
    >>  * pull_task - move a task from a remote runqueue to the local runqueue.
    >>  * Both runqueues must be locked.
    >> --
    >> 1.7.7.6
    >>
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-01-31 13:23    [W:0.034 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site