lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dmaengine: care sd_dma_address/len in dmaengine_prep_slave_single()
From
Date
On Mon, 2012-01-30 at 01:25 -0800, Kuninori Morimoto wrote:
> dmaengine_prep_slave_single() is helper macro of dmaengine.
> But it doesn't have sg_dma_address/len() settings which are required.
> And it used void *buf in parameter, but it should be dma_addr_t.
> This patch fixes up it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> include/linux/dmaengine.h | 9 +++++++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 75f53f8..f47c578 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -521,11 +521,16 @@ static inline int dmaengine_slave_config(struct dma_chan *chan,
> }
>
> static inline struct dma_async_tx_descriptor *dmaengine_prep_slave_single(
> - struct dma_chan *chan, void *buf, size_t len,
> + struct dma_chan *chan, dma_addr_t buf, size_t len,
> enum dma_data_direction dir, unsigned long flags)
dma_transfer_direction... this is not based on 3.3-rc1 or
slave-dma/next?

> {
> struct scatterlist sg;
> - sg_init_one(&sg, buf, len);
> +
> + sg_init_table(&sg, 1);
> + sg_set_page(&sg, pfn_to_page(PFN_DOWN(buf)),
> + len, offset_in_page(buf));
> + sg_dma_address(&sg) = buf;
> + sg_dma_len(&sg) = len;
>
> return chan->device->device_prep_slave_sg(chan, &sg, 1, dir, flags);
> }


--
~Vinod



\
 
 \ /
  Last update: 2012-01-30 10:57    [W:0.051 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site