lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] module: Remove module size limit
From
Date
Rusty,

I'm not sure why git forgot to add the 'From' line, but if you do merge
it please add:

From: Sasha Levin <sasha.levin@oracle.com>

Thanks!

On Mon, 2012-01-30 at 23:07 -0500, Sasha Levin wrote:
> Module size was limited to 64MB, this was legacy limitation due to vmalloc()
> which was removed a while ago.
>
> Limiting module size to 64MB is both pointless and affects real world use
> cases.
>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Tim Abbott <tim.abbott@oracle.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
> kernel/module.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index 2c93276..3d56b6f 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2380,8 +2380,7 @@ static int copy_and_check(struct load_info *info,
> return -ENOEXEC;
>
> /* Suck in entire file: we'll want most of it. */
> - /* vmalloc barfs on "unusual" numbers. Check here */
> - if (len > 64 * 1024 * 1024 || (hdr = vmalloc(len)) == NULL)
> + if ((hdr = vmalloc(len)) == NULL)
> return -ENOMEM;
>
> if (copy_from_user(hdr, umod, len) != 0) {


--

Sasha.



\
 
 \ /
  Last update: 2012-01-31 05:15    [W:0.045 / U:4.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site