lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 3/5] drivers/dma/amba-pl08x.c: adjust double test
From
Date
On Thu, 2012-01-12 at 22:49 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Rewrite a duplicated test to test the correct value
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E;
> @@
>
> (
> * E
> || ... || E
> |
> * E
> && ... && E
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> There is a dstbus field, so it is my guess that that should be tested
> instead of testing the srcbus field again.
>
> drivers/dma/amba-pl08x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 8a28158..840c6c0 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -649,7 +649,7 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x,
> }
>
> if ((bd.srcbus.addr % bd.srcbus.buswidth) ||
> - (bd.srcbus.addr % bd.srcbus.buswidth)) {
> + (bd.dstbus.addr % bd.dstbus.buswidth)) {
> dev_err(&pl08x->adev->dev,
> "%s src & dst address must be aligned to src"
> " & dst width if peripheral is flow controller",
>
Applied thanks

--
~Vinod



\
 
 \ /
  Last update: 2012-01-31 04:27    [W:0.032 / U:6.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site