Messages in this thread | | | Subject | Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req | From | Joe Perches <> | Date | Mon, 30 Jan 2012 15:45:03 -0800 |
| |
On Mon, 2012-01-30 at 17:35 -0600, Larry Finger wrote: > The patch is OK, but the patch subject is bad. You should have "[PATCH] > rtlwifi:...". Your patch is for rtlwifi, not wireless.
Hi Devendra.
A reasonable rule of thumb is use the deepest directory path basename you can to prefix the patch. Something like:
[PATCH] $(basename $(dirname $file)): terse description
If you are patching drivers/net/ethernet/realtek/apt.c this becomes:
[PATCH] realtek: terse description
There are some exceptions though. One of them is if the patch is in staging, prefix with [PATCH] staging: $(basename $(dirname $file)): description
cheers, Joe
| |