lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf tools: remove .. in perf includes/
On 1/30/2012 11:14 AM, Arnaldo Carvalho de Melo wrote:
> Em Fri, Jan 20, 2012 at 12:36:44PM -0800, Andi Kleen escreveu:
>> From: Andi Kleen<ak@linux.intel.com>
>>
>> The perf user space has a lot of includes with ugly .. chains. This also
>> makes it impossible to include any perf files from other code.
>>
>> I think the original reason for this were some wrapper include files
>> for the kernel includes, and the explicit paths were needed to avoid
>> endless recursion. A better way to handle this is #include_next
>>
>> - Add all the relevant directories as -I in the Makefile
>> - Remove (near) all the .. in include statements
>> - Remove unnecessary wrappers that do nothing
>> - Fix up some fallout
>>
>> This makes the code more pleasant to read.
>>
>> I did it all in one big patch to keep bisectability.
> It builds, but breaks this:

Hmm cannot reproduce. The extra tarball builds fine and includes memset_64.S
with my patch on Linus latest.

-Andi




\
 
 \ /
  Last update: 2012-01-30 22:47    [W:0.035 / U:6.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site