lkml.org 
[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] procfs: Export next_tgid(), move it to kernel/pid.c
On Sun, Jan 29, 2012 at 06:22:42PM -0800, Greg KH wrote:
> On Mon, Jan 30, 2012 at 05:13:23AM +0400, Anton Vorontsov wrote:
> > We'd like to use this function in the android low memory killer driver, so
> > let's export it.
>
> Why is it needed?
>
> I _REALLY_ don't want to add any exports to any part of the kernel for
> the android low memory stuff. That is because it is not something that
> should be touching anything else, especially as numerous people disagree
> with what it does and how it does it.
>
> Instead, you should be spending the time and effort to properly
> implement this, as has been discussed numerous times, the last one a
> mere few weeks ago when someone tried adding the nokia-specific low
> memory killer/notifier code.

Yep, and I fully agree here. But doing it the right way (i.e. teaching
Android to use low memory notifiers) will take some time. And improving
current driver meanwhile is just my sub-task.

> So no, sorry, I will not take these patches, unless you come up with
> some very good justifications why.

Well, actually, this patches were born as a response to LMK review[1]
by KOSAKI Motohiro, he did not like the tasklist lock. Though, I agree
that it might be not a great idea to export API for the driver that
is about to superseded by a different approach (i.e. notifiers). :-)

Heh. But you never know where you'll end up before you actually
try to do something. I have tried to get rid of the tacklist lock,
and it appears that it causes more trouble. :-)

[1] http://lkml.org/lkml/2011/12/19/294

--
Anton Vorontsov
Email: cbouatmailru@gmail.com


\
 
 \ /
  Last update: 2012-01-30 20:53    [W:0.061 / U:28.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site