[lkml]   [2012]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] um: Use generic io.h
On Mon, Jan 30, 2012 at 06:23:33PM +0000, Al Viro wrote:
> On Wed, Jan 25, 2012 at 06:23:53PM +0100, Richard Weinberger wrote:
> > There is no need to implement our own basic io functions.
> > All we need exists already in asm-generic/io.h
> Then just do
> git rm arch/um/include/asm/io.h
> echo 'generic-y += io.h' >>arch/um/include/asm/Kbuild
> git add arch/um/include/asm/Kbuild
> and be done with that. We are already using generic-y for a bunch of
> headers there...

While we are at it, param.h and pci.h appear to be candidates for the
same treatment, along with delay.h and auxvec.h. mutex.h as well...
BTW, we probably can kill arch/um/include/asm/asm-offsets.h - everything
in there is using generated/asm-offsets.h directly.

FWIW, I'd probably kill current.h as well - replace get_current() in
arch/um/kernel/process.c with get_current_pid() (i.e. task_pid_nr(current)),
kill HOST_TASK_PID and switch arch/x86/um/bugs_32.c to use of get_current_pid()
and we can switch to asm-generic/current.h just fine.

 \ /
  Last update: 2012-01-30 20:29    [W:0.065 / U:3.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site